fix(nextjs): fix inlined workspace root in .nx-helpers #27136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8dc6383. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
ndcunningham
approved these changes
Jul 26, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 30, 2024
This PR fixes an issue where our `withNx` function for Next.js is compiled with inlined `workspaceRoot` (to support container environments). On Windows, we write the `.nx-helpers/with-nx.js` with the following: ```js workspaceRoot: 'C:\Users\user\projects\app', ``` The `\u` character result in a Node error: `Invalid Unicode escape sequence`. The fix is to escape `\` as `\\`, so when the file is written, the path is valid and does not cause unicode errors. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #18824 (cherry picked from commit 4ab9e6d)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where our
withNxfunction for Next.js is compiled with inlinedworkspaceRoot(to support container environments). On Windows, we write the.nx-helpers/with-nx.jswith the following:The
\ucharacter result in a Node error:Invalid Unicode escape sequence.The fix is to escape
\as\\, so when the file is written, the path is valid and does not cause unicode errors.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #18824