-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(core): document projectsAffectedByDependencyUpdates #27134
docs(core): document projectsAffectedByDependencyUpdates #27134
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bdaffae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
docs/shared/using-nx/affected.md
Outdated
@@ -244,6 +244,22 @@ Nx provides two methods to exclude glob patterns (files and folders) from `affec | |||
- Glob patterns defined in your `.gitignore` file are ignored. | |||
- Glob patterns defined in an optional `.nxignore` file are ignored. | |||
|
|||
## Marking Projects Affected by Dependency Updates | |||
|
|||
By default Nx will mark all projects as affected whenever your package manager's lock file changes. This is meant to be a failsafe in case Nx misses a project that should be affected by a dependency update. If you'd like to opt in to a smarter behavior you can configure Nx to only mark projects as affected if they actually depend on the updated packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Missing comma after "default -
By default, Nx...
- I would be more precise on "this is" for documentation, and we can remove
mean to be
since it's superfluous --This behavior is a failsafe in case Nx...
7c68f7f
to
bdaffae
Compare
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior No docs for new config flag ## Expected Behavior Docs 🎉 ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #22259
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior No docs for new config flag ## Expected Behavior Docs 🎉 ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #22259 (cherry picked from commit 8e596c3)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
No docs for new config flag
Expected Behavior
Docs 🎉
Related Issue(s)
Fixes #22259