fix(core): show target description, add metadata to schema, and docum… #27131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenPandaz
requested review from
a team,
philipjfulcher,
bcabanes,
MaxKless and
xiongemi
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8a46349. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Jul 25, 2024
FrozenPandaz
force-pushed
the
metadata-docs
branch
from
bf1e7ae to
e7f46d0
Compare
FrozenPandaz
force-pushed
the
metadata-docs
branch
from
e7f46d0 to
8a46349
Compare
MaxKless
approved these changes
Jul 26, 2024
FrozenPandaz
added a commit
that referenced
this pull request
Aug 1, 2024
#27131) …ent it <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Target description is not shown in the PDV. Also, being able to set a description in `project.json` is not in the schema nor is it documented. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Target descriptions are shown in the PDV. Also, being able to set a description in `project.json` is in the schema and documented on https://nx-dev-git-metadata-docs-nrwl.vercel.app/project-configuration#target-metadata  ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #19355 (cherry picked from commit 381efa8)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent it
Current Behavior
Target description is not shown in the PDV.
Also, being able to set a description in
project.jsonis not in the schema nor is it documented.Expected Behavior
Target descriptions are shown in the PDV.
Also, being able to set a description in
project.jsonis in the schema and documented on https://nx-dev-git-metadata-docs-nrwl.vercel.app/project-configuration#target-metadataRelated Issue(s)
Fixes #19355