Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): improve bandwidth usage convert gif to mp4 #27129

Merged
merged 1 commit into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/blog/2024-05-08-nx-19-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Notice how all tasks are now appropriately grouped in the `E2E (CI)` group!

You can also find the same enhancements in Nx Cloud. Below is a view of all tasks in the [CI pipeline](https://staging.nx.app/runs/ctbAZfiLy3):

[![Grouped e2e tests in Nx Cloud](/blog/images/2024-05-08/nx-cloud-atomizer-groupings.gif)](https://staging.nx.app/runs/ctbAZfiLy3)
{% video-player src="/documentation/blog/media/2024-05-08/nx-cloud-atomizer-groupings.mp4" alt="Showing the Atomizer in Nx Cloud" link="https://staging.nx.app/runs/ctbAZfiLy3" /%}

Notice how all e2e groups are collapsed by default to give a concise view, while allowing you to expand to see how each individual task is progressing!

Expand Down Expand Up @@ -160,7 +160,7 @@ Since Nx 18 release, we also started using Project Crystal inside of the Nx repo

You can find a full list of fixes and features applied in this major release [here](https://github.com/nrwl/nx/releases/tag/19.0.0).

[![Changelog for Nx 19](/blog/images/2024-05-08/fixes.gif)](https://github.com/nrwl/nx/releases/tag/19.0.0)
{% video-player src="/documentation/blog/media/2024-05-08/fixes.mp4" alt="A display listing the Github changelog" /%}

With Project Crystal landed now, we're also adjusting our priorities to place a higher importance on stability. You should see this reflected in Nx 19.

Expand All @@ -182,7 +182,7 @@ In February, we launched two big enhancements to Nx Cloud: the [Atomizer](/ci/fe

Since then, the Atomizer has received a nice UI update (as we had seen earlier):

[![Grouped e2e tests in Nx Cloud](/blog/images/2024-05-08/nx-cloud-atomizer-groupings.gif)](https://staging.nx.app/runs/ctbAZfiLy3)
{% video-player src="/documentation/blog/media/2024-05-08/nx-cloud-atomizer-groupings.mp4" alt="Showing the Atomizer in Nx Cloud" link="https://staging.nx.app/runs/ctbAZfiLy3" /%}

Since February, we also revamped our task distribution algorithms. This has resulted in a 5-20% (depending on the repo) increase in both speed and cost efficiency for our users.

Expand Down
Binary file removed docs/blog/images/2024-05-08/fixes.gif
Binary file not shown.
Binary file not shown.
Binary file added docs/blog/media/2024-05-08/fixes.mp4
Binary file not shown.
Binary file not shown.
3 changes: 3 additions & 0 deletions nx-dev/ui-markdoc/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import { Pill } from './lib/tags/pill.component';
import { pill } from './lib/tags/pill.schema';
import { fence } from './lib/nodes/fence.schema';
import { FenceWrapper } from './lib/nodes/fence-wrapper.component';
import { VideoPlayer, videoPlayer } from './lib/tags/video-player.component';

// TODO fix this export
export { GithubRepository } from './lib/tags/github-repository.component';
Expand All @@ -83,6 +84,7 @@ export const getMarkdocCustomConfig = (
graph,
iframe,
'install-nx-console': installNxConsole,
'video-player': videoPlayer,
persona,
personas,
'project-details': projectDetails,
Expand Down Expand Up @@ -127,6 +129,7 @@ export const getMarkdocCustomConfig = (
Tweet,
YouTube,
VideoLink,
VideoPlayer,
// SvgAnimation,
},
});
Expand Down
42 changes: 42 additions & 0 deletions nx-dev/ui-markdoc/src/lib/tags/video-player.component.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import { VideoLoop } from './video-loop.component';
import { Schema } from '@markdoc/markdoc';

export const videoPlayer: Schema = {
render: 'VideoPlayer',
attributes: {
src: {
type: 'String',
required: true,
},
alt: {
type: 'String',
required: false,
},
link: {
type: 'String',
required: false,
},
},
};

export function VideoPlayer({
src,
alt,
link,
}: {
src: string;
alt: string;
link: string;
}): JSX.Element {
return (
<div className="overflow-x-auto">
{link ? (
<a href={link} target="_blank" rel="noreferrer">
<VideoLoop src={src} alt={alt}></VideoLoop>
</a>
) : (
<VideoLoop src={src} alt={alt}></VideoLoop>
)}
</div>
);
}