Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): locate npm nodes correctly for aliased packages #27124

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #27098

@leosvelperez leosvelperez self-assigned this Jul 25, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner July 25, 2024 16:26
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 4:29pm

@stephenwade
Copy link
Contributor

@leosvelperez @FrozenPandaz Can this be merged?

@stephenwade
Copy link
Contributor

@FrozenPandaz @vsavkin When will this be merged? I am eagerly waiting for this fix.

@AgentEnder AgentEnder merged commit 40d3516 into master Aug 7, 2024
6 checks passed
@AgentEnder AgentEnder deleted the core/project-locator-aliased-packages branch August 7, 2024 17:29
FrozenPandaz pushed a commit that referenced this pull request Aug 7, 2024
ZackDeRose pushed a commit to ZackDeRose/nx that referenced this pull request Aug 8, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generatePackageJson omits dependencies with package aliases
3 participants