Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): always load task envs from workspace root instead of relative to cwd #27120

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Jul 25, 2024

Current Behavior

task-specific .env files are only loaded when you're running from the workspace root.

Expected Behavior

task-specific .env files should be loaded regardless of the directory you're running from.

Related Issue(s)

Fixes #22846

@MaxKless MaxKless requested a review from a team as a code owner July 25, 2024 15:32
@MaxKless MaxKless requested a review from xiongemi July 25, 2024 15:32
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Jul 25, 2024 3:32pm

@AgentEnder AgentEnder merged commit 73536da into master Jul 25, 2024
6 checks passed
@AgentEnder AgentEnder deleted the load-task-env-from-workspaceroot branch July 25, 2024 16:29
FrozenPandaz pushed a commit that referenced this pull request Jul 30, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.env files not loaded when CWD is not workspace root
2 participants