feat(misc): prioritize github onboarding flow #27085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
mandarini
requested review from
FrozenPandaz and
catfireparty
and removed request for
Cammisuli
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 57245c5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
mandarini
force-pushed
the
feat/prioritize-github-flow
branch
from
8f1068d to
b29c970
Compare
mandarini
force-pushed
the
feat/prioritize-github-flow
branch
from
b29c970 to
57245c5
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-27085-57245c5
To request a new release for this pull request, mention someone from the Nx team or the |
FrozenPandaz
approved these changes
Jul 24, 2024
ndcunningham
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Prioritized remotes in the order: `origin`, `upstream`, `base`, and then the first remote found, when trying to determine if repo uses GitHub. * Implemented fallback to a default GitHub onboarding URL (`/setup/connect-workspace/github/select`) if no remotes are found. * Added corresponding unit tests to verify the new remote priority order and fallback behavior.
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Prioritized remotes in the order: `origin`, `upstream`, `base`, and then the first remote found, when trying to determine if repo uses GitHub. * Implemented fallback to a default GitHub onboarding URL (`/setup/connect-workspace/github/select`) if no remotes are found. * Added corresponding unit tests to verify the new remote priority order and fallback behavior. (cherry picked from commit 7a642ee)
This was referenced Jul 26, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
origin,upstream,base, and then the first remote found, when trying to determine if repo uses GitHub./setup/connect-workspace/github/select) if no remotes are found.