-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misc): add more logging while running migrations #27063
feat(misc): add more logging while running migrations #27063
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7ced96f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
The e2e tests in As fix, I used a helper function based on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/random#getting_a_random_integer_between_two_values to ensure that the random value always has 7 digits. |
@DanielRose Thanks so much for figuring out that cause, it's been on my list for a while but it's been rare enough that it's never jumped to the highest priority. I think we can further simplify the implementation details by just using Please could you revert yours and pull that in? |
The user previously had no feedback on how far the migrations have progressed, unless any changes were done. Especially if there are many long-running migration steps, this was unsatisfactory.
Rebased on the latest state, excluding the test fixes. |
Thanks again, @DanielRose! |
(cherry picked from commit adbb861)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When running migrations, the user currently only sees any logging feedback when a migration has done any changes.
This causes the following problems:
Expected Behavior
This adds some more logging: