Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): added missing close bracket #27023

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

arthur-mountain
Copy link
Contributor

@arthur-mountain arthur-mountain commented Jul 21, 2024

Current Behavior

There is a missing closing bracket in the cache-task-result

Screenshot 2024-07-21 at 2 22 01 PM

Expected Behavior

Add the missing closing bracket: change {projectName to {projectName}.

Related Issue(s)

N/A!

@arthur-mountain arthur-mountain requested a review from a team as a code owner July 21, 2024 06:24
Copy link

vercel bot commented Jul 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 21, 2024 7:10am

@arthur-mountain arthur-mountain force-pushed the fix/cache-task-results branch from 767afaf to dc7f1e3 Compare July 21, 2024 07:03
@arthur-mountain arthur-mountain changed the title docs(cache): add missing close bracket docs(shared): add missing close bracket Jul 21, 2024
@arthur-mountain arthur-mountain changed the title docs(shared): add missing close bracket docs(shared): added missing close bracket Jul 22, 2024
@leosvelperez leosvelperez changed the title docs(shared): added missing close bracket docs(core): added missing close bracket Jul 22, 2024
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@leosvelperez leosvelperez merged commit f366d4e into nrwl:master Jul 22, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jul 22, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

There is a missing closing bracket in the
[cache-task-result](https://nx.dev/features/cache-task-results#finetune-caching-with-inputs-and-outputs)

<img width="696" alt="Screenshot 2024-07-21 at 2 22 01 PM"
src="https://github.com/user-attachments/assets/4a798a3a-3869-46e9-bd0b-cb762034a70f">

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Add the missing closing bracket: change `{projectName` to
`{projectName}`.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->
N/A!

(cherry picked from commit f366d4e)
@arthur-mountain arthur-mountain deleted the fix/cache-task-results branch July 23, 2024 15:12
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants