Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow overriding NX_PARALLEL with --parallel #27016

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

NX_PARALLEL overrides --parallel flag

Expected Behavior

--parallel is more specific so it should override NX_PARALLEL

Related Issue(s)

Fixes #26903

@AgentEnder AgentEnder requested a review from a team as a code owner July 19, 2024 20:38
@AgentEnder AgentEnder requested a review from FrozenPandaz July 19, 2024 20:38
Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 7:46pm

@AgentEnder AgentEnder force-pushed the fix/nx-parallel-cli branch from 7dbae40 to 6ab3bb8 Compare July 24, 2024 19:44
@AgentEnder AgentEnder merged commit 0104ea4 into master Jul 24, 2024
6 checks passed
@AgentEnder AgentEnder deleted the fix/nx-parallel-cli branch July 24, 2024 21:41
FrozenPandaz pushed a commit that referenced this pull request Jul 24, 2024
@SebastienGllmt
Copy link

Not fully convinced of this change. The rationale for NX_PARALLEL's creation was so that you could set a high parallel for dev machines, while setting a low NX_PARALLEL for CI so that it doesn't blow up on cheap CI machines

This PR means that you effectively have to always do --parallel=${NX_PARALLEL:-3} on all your calls now to maintain the high parallel on desktop with low parallel on CI, but if you now need to manually specify this everywhere it's not as clear why NX_PARALLEL is a built-in feature

Maybe there is another use-case that I'm not thinking of

Copy link

github-actions bot commented Aug 4, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core:runCommands: explicit --parallel argument doesn't override env variable NX_PARALLEL
3 participants