Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-federation): do not cache assets from static serve #27005

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jul 19, 2024

We're currently caching files for an hour when serving the host with static remotes. This PR fixes the issue by setting cacheSeconds: -1 on the static server (disables cache).

This affects development only.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested review from a team as code owners July 19, 2024 13:29
@jaysoo jaysoo requested review from xiongemi and leosvelperez July 19, 2024 13:29
Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 1:31pm

@jaysoo jaysoo merged commit 8b1c78c into master Jul 19, 2024
6 checks passed
@jaysoo jaysoo deleted the fix/mf-static-serve-cache branch July 19, 2024 14:39
FrozenPandaz pushed a commit that referenced this pull request Jul 22, 2024
We're currently caching files for an hour when serving the host with
static remotes. This PR fixes the issue by setting `cacheSeconds: -1` on
the static server (disables cache).

This affects development only.
<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 8b1c78c)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants