Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): normalizeTargetDependencyWithStringProjects should not return undefined #26994

Merged

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #26975

@xiongemi xiongemi requested a review from a team as a code owner July 18, 2024 19:28
@xiongemi xiongemi requested a review from AgentEnder July 18, 2024 19:28
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 4:27pm

@tomalaforge
Copy link
Contributor

I tested it on my issue and it fixes it. Thanks 🔥

@xiongemi xiongemi force-pushed the fix/fix-undefined-normalizeTargetDependencyWithStringProjects branch from ab17030 to de44999 Compare July 19, 2024 16:25
@xiongemi xiongemi enabled auto-merge (squash) July 19, 2024 16:33
@xiongemi xiongemi merged commit 188f0d8 into master Jul 19, 2024
6 checks passed
@xiongemi xiongemi deleted the fix/fix-undefined-normalizeTargetDependencyWithStringProjects branch July 19, 2024 16:58
FrozenPandaz pushed a commit that referenced this pull request Jul 22, 2024
…urn undefined (#26994)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26975

(cherry picked from commit 188f0d8)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lerna (powered by Nx) Cannot read properties of undefined (reading 'projects')
3 participants