fix(rollup): always generate package.json when using @nx/rollup:rollup #26940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8e96750. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/rollup-package-json
branch
from
f3cf053 to
5122b9d
Compare
ndcunningham
approved these changes
Jul 15, 2024
jaysoo
force-pushed
the
fix/rollup-package-json
branch
2 times, most recently
from
5fb2b24 to
363cbdd
Compare
jaysoo
force-pushed
the
fix/rollup-package-json
branch
from
363cbdd to
8e96750
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 16, 2024
#26940) Prior to Nx 19.4, the `@nx/rollup:rollup` executor generates `package.json` outside of the actual Rollup build. Nx 19.4 changed this to be a proper Rollup plugin in order to support inferred targets better. This led to a slight regression, where projects that override `plugins` array in their `rollup.config.js` file will also remove the `generatePackageJson` plugin. This PR brings the behavior back, so the `package.json` file is _always_ generated regardless of how the `plugins` array is customized. <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 34da542)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to Nx 19.4, the
@nx/rollup:rollupexecutor generatespackage.jsonoutside of the actual Rollup build. Nx 19.4 changed this to be a proper Rollup plugin in order to support inferred targets better. This led to a slight regression, where projects that overridepluginsarray in theirrollup.config.jsfile will also remove thegeneratePackageJsonplugin.This PR brings the behavior back, so the
package.jsonfile is always generated regardless of how thepluginsarray is customized.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #