Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): add NX_E2E_RUN_E2E env to e2eInputs #26939

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented Jul 15, 2024

Current Behavior

E2E tests do not take NX_E2E_RUN_E2E as an input. This means running an e2e test without and then with will result in a cache hit even though it modifies the behaviour.

Expected Behavior

The used env var should be an input.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 15, 2024 2:07pm

@MaxKless MaxKless enabled auto-merge (squash) July 15, 2024 14:18
@MaxKless MaxKless merged commit 33d2bec into master Jul 15, 2024
6 checks passed
@MaxKless MaxKless deleted the e2e-inputs-fix branch July 15, 2024 14:46
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants