Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): add Nx Cloud Page #26865

Merged
merged 7 commits into from
Jul 19, 2024
Merged

feat(nx-dev): add Nx Cloud Page #26865

merged 7 commits into from
Jul 19, 2024

Conversation

ndcunningham
Copy link
Contributor

No description provided.

@ndcunningham ndcunningham self-assigned this Jul 8, 2024
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 19, 2024 3:49pm

@jaysoo
Copy link
Member

jaysoo commented Jul 16, 2024

Let's move the page to app router so we don't have to do it in the future. It also allows more optimizations with RSC if needed.

@ndcunningham ndcunningham force-pushed the feat/nx-dev-nx-cloud branch from 71ab1cf to 0476df6 Compare July 16, 2024 14:15
@bcabanes bcabanes changed the title feat(nx-dev): Add Nx Cloud Page feat(nx-dev): add Nx Cloud Page Jul 16, 2024
@bcabanes
Copy link
Member

Hi @ndcunningham!
Can you rebase your branch please?
With the merge of the new home page, there are some additional libraries available for you to use:

  • ui-icons for customer, technology, product, social, editor (etc...) icons
  • ui-animations for animation already used in the home screen

Also, the ui-common has been cleaned up, so you have to update the current imports to the right libraries.

nx-dev/ui-cloud/src/lib/call-to-action.tsx Outdated Show resolved Hide resolved
nx-dev/ui-cloud/src/lib/enhance-with-ai.tsx Outdated Show resolved Hide resolved
nx-dev/ui-cloud/src/lib/faster-and-cheaper.tsx Outdated Show resolved Hide resolved
nx-dev/ui-cloud/src/lib/faster-and-cheaper.tsx Outdated Show resolved Hide resolved
nx-dev/ui-cloud/src/lib/faster-and-cheaper.tsx Outdated Show resolved Hide resolved
@jaysoo jaysoo merged commit 51d5d23 into master Jul 19, 2024
6 checks passed
@jaysoo jaysoo deleted the feat/nx-dev-nx-cloud branch July 19, 2024 18:53
FrozenPandaz pushed a commit that referenced this pull request Jul 22, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants