fix(vite): Only attempt to amend test object if one exists #26822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test object is assigned using optional chaining but previously did not check that any value had actually been assigned which would cause the `getStart` call to fail resulting in a failed migration.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bc6ca70. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Jul 3, 2024
ndcunningham
approved these changes
Jul 9, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 12, 2024
Test object is assigned using optional chaining but previously did not check that any value had actually been assigned which would cause the `getStart` call to fail resulting in a failed migration. ## Current Behavior Migration fails if no matching test object is found. ## Expected Behavior Migration should not fail. ## Related Issue(s) I haven't opened an issue, just the PR. I can open an issue if required for tracking. (cherry picked from commit 8fd38cb)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test object is assigned using optional chaining but previously did not check that any value had actually been assigned which would cause the
getStartcall to fail resulting in a failed migration.Current Behavior
Migration fails if no matching test object is found.
Expected Behavior
Migration should not fail.
Related Issue(s)
I haven't opened an issue, just the PR. I can open an issue if required for tracking.