Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module-federation): use @module-federation/enhanced for withModuleFederation #26777

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jul 1, 2024

Current Behavior

We currently use the ModuleFederationPlugin from webpack itself.
This doesn't receive the same attention as the new @module-federation/enhanced package, which is where all new work by Zack Jackson and Bytedance is being conducted.

Expected Behavior

Our withModuleFederation utils should use the @module-federation/enhanced package.

Related Issue(s)

#26322
Fixes #

@Coly010 Coly010 requested a review from jaysoo as a code owner July 1, 2024 10:48
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2024 8:20pm

@Coly010 Coly010 requested a review from a team as a code owner July 1, 2024 10:48
@Coly010 Coly010 self-assigned this Jul 1, 2024
@Coly010 Coly010 requested review from a team as code owners July 1, 2024 10:48
@Coly010 Coly010 requested a review from AgentEnder July 1, 2024 10:48
@jaysoo jaysoo merged commit a6522f7 into master Jul 5, 2024
6 checks passed
@jaysoo jaysoo deleted the mf/enhanced branch July 5, 2024 13:48
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants