Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not re-register ts-node twice for the same compiler opt… #26758

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Jun 28, 2024

…ions

Current Behavior

Registering many copies of ts-node causes Nx to run out of memory loading config files.

Expected Behavior

Registering ts-node only happens once per unique compiler options. It probably is still too often but it should be enough to fix the OOM issues?

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner June 28, 2024 19:09
@FrozenPandaz FrozenPandaz requested a review from xiongemi June 28, 2024 19:09
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 7:34pm

@FrozenPandaz FrozenPandaz marked this pull request as draft June 28, 2024 19:09
@FrozenPandaz FrozenPandaz marked this pull request as ready for review June 28, 2024 20:31
@AgentEnder AgentEnder merged commit b2fecea into master Jun 28, 2024
6 checks passed
@AgentEnder AgentEnder deleted the fix-tsnode branch June 28, 2024 20:38
Copy link

github-actions bot commented Jul 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants