Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): dependency checks should respect pnpm workspace versions #26709

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #26707

@meeroslav meeroslav self-assigned this Jun 26, 2024
@meeroslav meeroslav requested a review from a team as a code owner June 26, 2024 20:14
@meeroslav meeroslav requested a review from JamesHenry June 26, 2024 20:14
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 8:16pm


it('should require swc if @nx/js:swc executor', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test has been moved into describe block from outside

@meeroslav meeroslav merged commit 7f8bb4b into master Jun 27, 2024
6 checks passed
@meeroslav meeroslav deleted the fix/pnpm-workspace-deps-check branch June 27, 2024 15:19
Copy link

github-actions bot commented Jul 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency-checks rule does not respect the pnpm workspace: * version signature
2 participants