Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): add comment to explain useLegacyNxPlugin and how to remove it #26696

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jun 26, 2024

This PR adds a comment when useLegacyNxPlugin is used so users know what it is, and how they can remove it.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner June 26, 2024 14:41
@jaysoo jaysoo requested a review from Coly010 June 26, 2024 14:41
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 6:16pm

@jaysoo jaysoo force-pushed the fix/add-comments-for-webpack-legacy-plugin branch 2 times, most recently from 47cee7e to b03dd76 Compare June 26, 2024 18:03
@jaysoo jaysoo force-pushed the fix/add-comments-for-webpack-legacy-plugin branch from b03dd76 to 1226f3e Compare June 26, 2024 18:13
@jaysoo jaysoo merged commit 86412cb into master Jun 26, 2024
6 checks passed
@jaysoo jaysoo deleted the fix/add-comments-for-webpack-legacy-plugin branch June 26, 2024 18:44
Copy link

github-actions bot commented Jul 2, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants