fix(module-federation): module-federation-dev-server hang caused by child process exiting too early (#26684) #26685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rocess exiting too early (nrwl#26684)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ccbb8ff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
changed the title
Coly010
changed the title
Coly010
approved these changes
Jun 26, 2024
|
@jooskim Thank you for the detailed Issue and the work done investigating and resolving this problem. Your contribution is very appreciated! |
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 26, 2024
…hild process exiting too early (#26684) (#26685) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior See #26684 ## Expected Behavior See #26684 Fixes #26684 --- This fix is targeted at NX 19. For a backport to NX 18, a small, trivial change is necessary. I will file another PR targeting NX 18. --------- Co-authored-by: Colum Ferry <[email protected]> (cherry picked from commit 93b3e21)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
See #26684
Expected Behavior
See #26684
Fixes #26684
This fix is targeted at NX 19. For a backport to NX 18, a small, trivial change is necessary. I will file another PR targeting NX 18.