Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): allow disabling GitHub username matching in default changelog renderer #26672

Merged

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

If users want author data, but not for that author data to be linked to GitHub usernames (or associated requests made to ungh.cc), they must provide a custom changelog renderer.

Expected Behavior

Users can opt out of the GitHub usernames lookup and matching by setting mapAuthorsToGitHubUsernames in their renderOptions to false.

Related Issue(s)

Fixes #26311

@JamesHenry JamesHenry requested review from a team as code owners June 25, 2024 12:41
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 25, 2024 0:45am

@JamesHenry JamesHenry merged commit 3a2e8d4 into master Jun 25, 2024
6 checks passed
@JamesHenry JamesHenry deleted the default-changelog-renderer-toggle-gh-username-matching branch June 25, 2024 17:46
FrozenPandaz pushed a commit that referenced this pull request Jun 26, 2024
Copy link

github-actions bot commented Jul 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of ungh.cc is not documented and potential security issue
3 participants