Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): uncomment start-ci-run #26645

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from FrozenPandaz as a code owner June 23, 2024 22:13
Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 9, 2024 10:14pm

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do it for the JS CI pipelines as well please?

@xiongemi xiongemi force-pushed the feature/nxc-769-enable-distribution-via-agents-by-default branch from cf5688c to 96a6eaa Compare June 25, 2024 17:24
@xiongemi xiongemi requested a review from a team as a code owner June 25, 2024 17:24
@xiongemi xiongemi requested a review from AgentEnder June 25, 2024 17:24
@xiongemi xiongemi force-pushed the feature/nxc-769-enable-distribution-via-agents-by-default branch 2 times, most recently from fa05c2f to ac28fed Compare June 26, 2024 02:57
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have it so this generator checks if Nx Cloud is enabled. If it is, have the step commented in. If not, have the step commented out.

Also, make sure the comments make sense for both cases.

When Nx Cloud is enabled, the comment should not mention connecting your workspace or enabling task distribution.

When Nx Cloud is not enabled, the comment should mention connecting thew orkspace and the to uncomment the line.

Use isNxCloudUsed

@xiongemi xiongemi force-pushed the feature/nxc-769-enable-distribution-via-agents-by-default branch from ac28fed to 3d88cc7 Compare July 9, 2024 18:50
@xiongemi xiongemi changed the title feat(gradle): uncomment start-ci-run feat(core): uncomment start-ci-run Jul 9, 2024
@xiongemi xiongemi force-pushed the feature/nxc-769-enable-distribution-via-agents-by-default branch from 3d88cc7 to acbb62e Compare July 9, 2024 19:04
@xiongemi xiongemi requested a review from a team as a code owner July 9, 2024 19:04
@xiongemi xiongemi force-pushed the feature/nxc-769-enable-distribution-via-agents-by-default branch from acbb62e to c4b8bc2 Compare July 9, 2024 19:10
@xiongemi xiongemi requested a review from FrozenPandaz July 9, 2024 19:10
@xiongemi xiongemi force-pushed the feature/nxc-769-enable-distribution-via-agents-by-default branch 4 times, most recently from 3e34cf4 to 0e9d84a Compare July 9, 2024 21:56
@xiongemi xiongemi force-pushed the feature/nxc-769-enable-distribution-via-agents-by-default branch from 0e9d84a to db934e0 Compare July 9, 2024 22:11
@FrozenPandaz FrozenPandaz merged commit 2b7b523 into master Jul 9, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the feature/nxc-769-enable-distribution-via-agents-by-default branch July 9, 2024 23:22
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants