-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): uncomment start-ci-run #26645
feat(core): uncomment start-ci-run #26645
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit db934e0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do it for the JS CI pipelines as well please?
cf5688c
to
96a6eaa
Compare
fa05c2f
to
ac28fed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have it so this generator checks if Nx Cloud is enabled. If it is, have the step commented in. If not, have the step commented out.
Also, make sure the comments make sense for both cases.
When Nx Cloud is enabled, the comment should not mention connecting your workspace or enabling task distribution.
When Nx Cloud is not enabled, the comment should mention connecting thew orkspace and the to uncomment the line.
Use isNxCloudUsed
ac28fed
to
3d88cc7
Compare
3d88cc7
to
acbb62e
Compare
acbb62e
to
c4b8bc2
Compare
3e34cf4
to
0e9d84a
Compare
0e9d84a
to
db934e0
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #