Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): Correctly collect lintable files for project in @nx/eslint plugin #26638

Merged

Conversation

gunter1020
Copy link
Contributor

Current Behavior

On Windows, the different path separators cause issues in determining whether a project has files that can be linted.

Expected Behavior

The project should correctly identify lintable files on Windows, regardless of the path separator used.

Related Issue(s)

Fixes #

@gunter1020 gunter1020 requested a review from a team as a code owner June 22, 2024 23:35
@gunter1020 gunter1020 requested a review from JamesHenry June 22, 2024 23:35
Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jul 4, 2024 5:08pm

@gunter1020 gunter1020 force-pushed the eslint/fix-lintable-files-collect branch from 34bb4d8 to ed7581a Compare June 25, 2024 11:13
@gunter1020 gunter1020 force-pushed the eslint/fix-lintable-files-collect branch from ed7581a to 39cb5c2 Compare July 3, 2024 14:46
@gunter1020 gunter1020 force-pushed the eslint/fix-lintable-files-collect branch from 39cb5c2 to afd4f79 Compare July 4, 2024 17:05
@AgentEnder AgentEnder merged commit a41a8d6 into nrwl:master Jul 15, 2024
5 checks passed
FrozenPandaz pushed a commit that referenced this pull request Jul 16, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants