fix(core): pick up changes to plugins configuration in daemon #26625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5a74f2a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Jun 24, 2024
| let loadedPlugins: LoadedNxPlugin[]; | ||
| let cleanup: () => void; | ||
|
|
||
| export async function getPlugins() { | ||
| if (loadedPlugins) { | ||
| const pluginsConfiguration = readNxJson().plugins ?? []; | ||
| const pluginsConfigurationHash = hashObject(pluginsConfiguration); |
There was a problem hiding this comment.
Likely works either way, but hashArray seems more appropriate
Comment on lines
+26
to
+28
| if (cleanup) { | ||
| cleanup(); | ||
| } |
There was a problem hiding this comment.
Currently isolated plugins don't actually return cleanup functions. I'll fix that.
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 24, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior - Isolated plugins return no-op cleanup function. ## Expected Behavior - Isolated plugins cleanup fn shuts them down. ## Related Issue(s) In #26625 we are starting to reload plugins when their configurations change. This makes sense, but means we should actually shutdown + reload workers. Fixes #
FrozenPandaz
added a commit
that referenced
this pull request
Jun 26, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The previous set of plugins are reused even when the plugins configuration change (plugins are added/removed or have their options changed). ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Plugins are cleaned up and reloaded when the plugins configuration change. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit cb4cff7)
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 26, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior - Isolated plugins return no-op cleanup function. ## Expected Behavior - Isolated plugins cleanup fn shuts them down. ## Related Issue(s) In #26625 we are starting to reload plugins when their configurations change. This makes sense, but means we should actually shutdown + reload workers. Fixes # (cherry picked from commit 3b2c42a)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The previous set of plugins are reused even when the plugins configuration change (plugins are added/removed or have their options changed).
Expected Behavior
Plugins are cleaned up and reloaded when the plugins configuration change.
Related Issue(s)
Fixes #