Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): generate npm lockfile with correct hoisted dependencies #26539

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jun 13, 2024

Failing new test case covering the broken scenario: https://staging.nx.app/runs/s0YaQGUVgq/task/nx%3Atest

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #22386

@leosvelperez leosvelperez self-assigned this Jun 13, 2024
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 10:44am

@leosvelperez leosvelperez marked this pull request as ready for review June 13, 2024 10:38
@leosvelperez leosvelperez requested review from meeroslav and a team as code owners June 13, 2024 10:38
@leosvelperez leosvelperez requested a review from AgentEnder June 13, 2024 10:38
@leosvelperez leosvelperez merged commit 6cf0dbd into master Jun 13, 2024
6 checks passed
@leosvelperez leosvelperez deleted the core/fix-npm-parser-hoisting-issue branch June 13, 2024 14:28
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generatePackageJson creates out-of-sync lock file
2 participants