feat(webpack): add convertConfigToWebpackPlugin #26516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 25455c7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
2 times, most recently
from
20b3bd3 to
bd2e85c
Compare
ndcunningham
commented
Jun 12, 2024
| @@ -76,7 +76,7 @@ export function normalizeOptions( | |||
|
|
|||
| const sourceRoot = projectNode.data.sourceRoot ?? projectNode.data.root; | |||
|
|
|||
| if (!options.main) { | |||
| if (!combinedPluginAndMaybeExecutorOptions.main) { | |||
There was a problem hiding this comment.
This should be checking the combined options (executor and config) and not only what has been set inside the config.
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
bd2e85c to
941d0f2
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
941d0f2 to
ae5cad4
Compare
ndcunningham
requested review from
FrozenPandaz,
jaysoo,
AgentEnder and
a team
as code owners
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
ae5cad4 to
6b37da6
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
2 times, most recently
from
7c38035 to
487912b
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
487912b to
371a13d
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
371a13d to
de7a524
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
de7a524 to
f15f356
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
f15f356 to
402c1c6
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
402c1c6 to
484c11d
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
484c11d to
63fc1be
Compare
ndcunningham
force-pushed
the
feat/webpack-migrate-to-webpack-app-plugin
branch
from
63fc1be to
25455c7
Compare
jaysoo
approved these changes
Jun 21, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces functionality for users who currently use the
withNxandwithReactplugins in their webpack configuration to migrate to theNxAppWebpackPlugin.The
nxUseLegacyPluginwraps the legacy style function so that it continues to work with the standardized generated webpack config.By implementing this change, the aim is to provide a consistent method for users opting to transition to inferred targets. This ensures a smoother migration process, offering better integration and reducing potential configuration complexities.