Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): false positive npm dist-tag add #26496

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

npm dist-tag add can be run when not desired if exactly one version of a package exists in a registry (because in this case the data type of the versions field is a string instead of an array of strings (WAT)).

Expected Behavior

npm dist-tag add is only run when appropriate

Related Issue(s)

Fixes #26240

@JamesHenry JamesHenry requested a review from a team as a code owner June 10, 2024 17:16
@JamesHenry JamesHenry requested a review from Coly010 June 10, 2024 17:16
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 5:18pm

@JamesHenry JamesHenry enabled auto-merge (squash) June 10, 2024 17:16
@JamesHenry JamesHenry requested review from jaysoo and removed request for Coly010 June 10, 2024 17:19
@JamesHenry JamesHenry self-assigned this Jun 10, 2024
@JamesHenry JamesHenry merged commit 29af58f into master Jun 10, 2024
6 checks passed
@JamesHenry JamesHenry deleted the npm-publish-normalize-versions branch June 10, 2024 18:18
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants