fix(core): expand env variables on load and unload #26459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5b278aa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
xiongemi
force-pushed
the
fix/nx-task-env
branch
from
d39721b to
1baf89b
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
from
1baf89b to
36699bf
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
2 times, most recently
from
1130c5f to
06d88a3
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
from
06d88a3 to
b429f53
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
2 times, most recently
from
e9f50c3 to
326ae0c
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
3 times, most recently
from
f65c3fe to
e58880f
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
from
e58880f to
17a82d7
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
from
17a82d7 to
7dcf0d8
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
2 times, most recently
from
7f62d19 to
d84ae63
Compare
xiongemi
force-pushed
the
fix/nx-task-env
branch
from
d84ae63 to
ba04e2d
Compare
FrozenPandaz
requested changes
Jun 25, 2024
xiongemi
force-pushed
the
fix/nx-task-env
branch
2 times, most recently
from
0a72ffb to
393abe7
Compare
Env variables using other variables were not unloaded from the environment and further customizations were impossible in more specific env files.
xiongemi
force-pushed
the
fix/nx-task-env
branch
from
393abe7 to
5b278aa
Compare
FrozenPandaz
approved these changes
Jun 25, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 26, 2024
This pr is meant to replace #22585 and #20524 Env variables using other variables were not unloaded from the environment and further customizations were impossible in more specific env files. <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23581 Co-authored-by: Mateo Tibaquira <[email protected]> (cherry picked from commit 88fd03b)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is meant to replace #22585 and #20524
Env variables using other variables were not unloaded from the environment and further customizations were impossible in more specific env files.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #23581