Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): add default baseUrl when extracting tsconfig.base.json or building libs will fail #26432

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jun 6, 2024

This PR ensures that "rootDir": "." is set in tsconfig.base.json is set, or else generating libs in a standalone project will fail with and error like this:

error TS5090: Non-relative paths are not allowed when 'baseUrl' is not set. Did you forget a leading './'?

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner June 6, 2024 18:58
@jaysoo jaysoo requested a review from ndcunningham June 6, 2024 18:58
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 7:03pm

@jaysoo jaysoo changed the title fix(js): add default rootDir when extracting tsconfig.base.json or building libs will fail fix(js): add default baseUrl when extracting tsconfig.base.json or building libs will fail Jun 6, 2024
@jaysoo jaysoo merged commit cc023c9 into master Jun 6, 2024
6 checks passed
@jaysoo jaysoo deleted the fix/NXC-719 branch June 6, 2024 20:10
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants