Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): don't load env vars when insantiating daemon client #26421

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

Constructing the daemon client automatically loads root env files. This happens as soon as the daemon client module has been loaded.

Expected Behavior

The nx process already loads root env files when the process starts. We shouldn't load them twice, and loading them here breaks some behavior in lerna.

nx-console will be updated to load .env files.

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner June 6, 2024 15:19
@AgentEnder AgentEnder requested a review from Cammisuli June 6, 2024 15:19
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Jun 6, 2024 3:19pm

@AgentEnder AgentEnder merged commit bb79c6d into master Jun 6, 2024
6 checks passed
@AgentEnder AgentEnder deleted the fix-lerna-env branch June 6, 2024 18:22
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants