Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): do not glob for invalid eslint config filenames in plugin #26409

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jun 6, 2024

Current Behavior

The @nx/eslint/plugin globs for .eslintrc.base.json and eslint.base.config.js workspace root files, which are not valid ESLint config filenames. The ESLint CLI wouldn't pick them up directly, and we shouldn't infer or process them. They are only used as part of a valid config file name that extends from them.

Expected Behavior

The @nx/eslint/plugin only globs for valid ESLint config filenames.

Related Issue(s)

Fixes #26388

@leosvelperez leosvelperez self-assigned this Jun 6, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner June 6, 2024 09:23
@leosvelperez leosvelperez requested a review from FrozenPandaz June 6, 2024 09:23
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 9:25am

@FrozenPandaz FrozenPandaz merged commit b40ed1f into master Jun 6, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the eslint/fix-plugin-glob-patterns branch June 6, 2024 13:12
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storybook "No Eslint configuration" issue after upgrading to v19
2 participants