fix(core): read project name from package json if not set in project json #26386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bea9f46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/project-name-project-json-package-json
branch
from
12d3bd6 to
8d7724b
Compare
FrozenPandaz
requested changes
Jun 7, 2024
| export function readNameFromPackageJson(path: string): string { | ||
| try { | ||
| const json = readJsonFile<PackageJson>(path); | ||
| return buildProjectConfigurationFromPackageJson(json, path, {}).name; |
There was a problem hiding this comment.
Do not reuse this function. Just read the correct properties.
AgentEnder
force-pushed
the
fix/project-name-project-json-package-json
branch
2 times, most recently
from
2e67567 to
22eb068
Compare
FrozenPandaz
requested changes
Jun 10, 2024
| projectJson.name = toProjectName(root); | ||
| writeJson(tree, `${root}/project.json`, projectJson); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please format files.
| // For existing projects, if the name is not set, we can inline it | ||
| // based on the existing logic. This makes sure folks aren't caught | ||
| // off guard by the new behavior. | ||
| if (!projectJson.name) { |
There was a problem hiding this comment.
Check if we have really changed the name before updating.
FrozenPandaz
requested changes
Jun 10, 2024
packages/nx/migrations.json
Outdated
| @@ -83,6 +83,12 @@ | |||
| "version": "19.2.2-beta.0", | |||
| "description": "Updates the nx wrapper.", | |||
| "implementation": "./src/migrations/update-17-3-0/update-nxw" | |||
| }, | |||
| "19-2-3-set-project-name": { | |||
| "version": "19.2.3-beta.0", | |||
There was a problem hiding this comment.
You'll have to update the version
AgentEnder
force-pushed
the
fix/project-name-project-json-package-json
branch
3 times, most recently
from
b1f37e1 to
92b3112
Compare
AgentEnder
force-pushed
the
fix/project-name-project-json-package-json
branch
from
92b3112 to
bea9f46
Compare
FrozenPandaz
approved these changes
Jun 12, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
If
project.jsonexists without a name, we infer one based on the root path. This can be confusing when there exists apackage.jsonalongside it that contains a name which doesn't match our inferred name.Expected Behavior
If
project.jsonandpackage.jsonboth exist, the name frompackage.jsonwill be used ifproject.jsoncontains no name.Related Issue(s)
Fixes #26347