Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): generate flat config for new projects correctly #26328

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jun 3, 2024

  • Change generated import for FlatCompat:
    - const FlatCompat = require('@eslint/eslintrc');
    + const { FlatCompat } = require('@eslint/eslintrc');
  • Fix replacing overrides to be reflected in the end result (the updated content with the replacements was not being assigned)
  • Add extended plugins/configs to the start (matches behavior of the old config)

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #22350
Fixes #26151

@leosvelperez leosvelperez self-assigned this Jun 3, 2024
@leosvelperez leosvelperez requested review from a team as code owners June 3, 2024 13:30
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 7:42am

@leosvelperez leosvelperez force-pushed the eslint/project-flat-config-generation branch from 3fd525c to 93a99b5 Compare June 4, 2024 07:40
@leosvelperez leosvelperez merged commit e95204b into master Jun 4, 2024
6 checks passed
@leosvelperez leosvelperez deleted the eslint/project-flat-config-generation branch June 4, 2024 12:11
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants