Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): react standalone tutorial #26304

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Conversation

isaacplmann
Copy link
Collaborator

Update the react standalone tutorial to start from npm create vite -- --template=react-ts

@isaacplmann isaacplmann requested a review from a team as a code owner June 1, 2024 00:01
@isaacplmann isaacplmann requested a review from juristr June 1, 2024 00:01
Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2024 1:39pm

docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Show resolved Hide resolved
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more notes I found.

Generate a CI workflow

  • run: npx nx affected -t lint test build e2e-ci

We don't generate the e2e-ci any more afaik.

docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Outdated Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Show resolved Hide resolved
docs/shared/tutorials/react-standalone.md Show resolved Hide resolved
@jaysoo jaysoo requested a review from juristr July 3, 2024 14:25
@isaacplmann isaacplmann enabled auto-merge (squash) July 3, 2024 17:59
@jaysoo jaysoo disabled auto-merge July 3, 2024 18:34
@jaysoo jaysoo merged commit 65c3e56 into master Jul 3, 2024
6 checks passed
@jaysoo jaysoo deleted the docs/react-vite-tutorial branch July 3, 2024 18:34
FrozenPandaz pushed a commit that referenced this pull request Jul 5, 2024
Update the react standalone tutorial to start from `npm create vite --
--template=react-ts`

(cherry picked from commit 65c3e56)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants