feat(linter): migrate to create-nodes-v2 #26302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bb87fe7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/eslint-create-nodes-v2
branch
from
48b790d to
af48c90
Compare
AgentEnder
force-pushed
the
feat/eslint-create-nodes-v2
branch
from
af48c90 to
6c0f2e7
Compare
AgentEnder
force-pushed
the
feat/eslint-create-nodes-v2
branch
from
d74c7f9 to
d93d253
Compare
FrozenPandaz
requested changes
Jun 3, 2024
| super( | ||
| [ | ||
| 'Failed to create nodes', | ||
| ...errors.map(([file, e]) => ` - ${file}: ${e.message}`), |
|
|
||
| export interface EslintPluginOptions { | ||
| targetName?: string; | ||
| extensions?: string[]; | ||
| } | ||
|
|
||
| const DEFAULT_EXTENSIONS = ['ts', 'tsx', 'js', 'jsx', 'html', 'vue']; | ||
| const ESLING_CONFIG_GLOB = combineGlobPatterns([ |
There was a problem hiding this comment.
Suggested change
| const ESLING_CONFIG_GLOB = combineGlobPatterns([ | |
| const ESLINT_CONFIG_GLOB = combineGlobPatterns([ |
| for (const file of context.configFiles) { | ||
| const nodes = await createNodes[1](file, { targetName }, context); | ||
| Object.assign(aggregateProjects, nodes.projects); | ||
| async function invokeCreateNodesV2OnMatchingFiles( |
There was a problem hiding this comment.
We don't need to change the name of this.
AgentEnder
force-pushed
the
feat/eslint-create-nodes-v2
branch
from
d93d253 to
9ae3b9a
Compare
AgentEnder
force-pushed
the
feat/eslint-create-nodes-v2
branch
from
9ae3b9a to
bb87fe7
Compare
FrozenPandaz
approved these changes
Jun 3, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
No cache for eslint nodes
Expected Behavior
v2 cache for eslint nodes
Related Issue(s)
Fixes #