Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): use createNodesV2 for cypress and playwright #26301

Merged
merged 1 commit into from
May 31, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Cypress and Playwright plugins use CreateNodesV1 and have issues running in parallel and in isolation.

Expected Behavior

Cypress and Playwright plugins use CreateNodesV2 and do not have issues running in parallel and in isolation.

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 31, 2024 9:00pm

@FrozenPandaz FrozenPandaz marked this pull request as ready for review May 31, 2024 21:49
@FrozenPandaz FrozenPandaz requested review from a team as code owners May 31, 2024 21:49
@FrozenPandaz FrozenPandaz requested a review from JamesHenry May 31, 2024 21:49
@AgentEnder AgentEnder merged commit 1e7cd7e into master May 31, 2024
6 checks passed
@AgentEnder AgentEnder deleted the plugins-v2 branch May 31, 2024 21:53
Copy link

github-actions bot commented Jun 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants