Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): add copy button for entire target configuration #26284

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented May 31, 2024

Current Behavior

Expected Behavior

Screenshot 2024-07-03 at 5 29 12 PM Screenshot 2024-07-03 at 5 29 03 PM

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2024 9:45pm

@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from 6a02888 to bd98644 Compare June 4, 2024 21:22
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from bd98644 to ed3fbec Compare June 4, 2024 22:03
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from ed3fbec to a99ed56 Compare June 5, 2024 05:08
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from a99ed56 to e7a7db7 Compare June 14, 2024 18:22
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from e7a7db7 to 68b5f73 Compare June 14, 2024 18:48
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from 68b5f73 to 2e09c89 Compare June 25, 2024 17:27
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from 2e09c89 to b1f9809 Compare June 27, 2024 03:45
@jaysoo jaysoo force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from b1f9809 to 95a9a52 Compare June 27, 2024 18:34
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever gets copied with the Copy Project button should be pastable into a project.json 🤔

Right now it is the project node.. which doesn't really help people.

@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from 95a9a52 to f280a28 Compare June 28, 2024 00:15
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from f280a28 to e4e0101 Compare June 28, 2024 00:28
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from e4e0101 to 6bbaaec Compare July 2, 2024 18:15
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from 6bbaaec to 9603119 Compare July 2, 2024 18:46
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch 2 times, most recently from 7d896d7 to 4f08890 Compare July 3, 2024 15:16
@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from 4f08890 to 9ba5e10 Compare July 3, 2024 15:58
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the screenshots and merge.

@xiongemi xiongemi force-pushed the feature/nxc-684-add-button-to-copy-entire-target-configuration branch from 9ba5e10 to 5925aba Compare July 3, 2024 21:37
@xiongemi xiongemi merged commit 311710e into master Jul 4, 2024
6 checks passed
@xiongemi xiongemi deleted the feature/nxc-684-add-button-to-copy-entire-target-configuration branch July 4, 2024 14:16
FrozenPandaz pushed a commit that referenced this pull request Jul 5, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
<img width="540" alt="Screenshot 2024-07-03 at 5 29 12 PM"
src="https://github.com/nrwl/nx/assets/16211801/bed98c56-3bd5-4170-893b-cefe5fe292f9">

<img width="1195" alt="Screenshot 2024-07-03 at 5 29 03 PM"
src="https://github.com/nrwl/nx/assets/16211801/544a4c4e-299f-40fc-a767-215d9c758dd8">

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 311710e)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants