fix(angular): module federation - devRemotes is made optional for static remotes #26265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not everyone is starting up MFE with --devRemotes but uses static remotes. this feature causes issues.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
MaxSassen
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1918dc5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
4 tasks
MaxSassen
changed the title
MaxSassen
changed the title
|
@leosvelperez first time opening a PR on git.. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new feature
module-federation: add remote configuration override (https://github.com/nrwl/nx/pull/19694)causes issues for developers that are using static remotes...Current Behavior
After upgrading and migrating Nx to 19.1.0, when I try to start my module federated host application using nx serve, I get a TypeError as shown in the failure logs.
If I use the command nx serve and specify --devRemotes, it works without any problems.
Expected Behavior
runs without --devRemotes
Related Issue(s)
#26169
#20973
Fixes
Not everyone is starting up MFE with --devRemotes but uses static remotes.
this feature causes issues.