fix(core): limit the amount of choices shown so that the prompt fits … #26132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 97707e0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
fix-init-choices
branch
from
25d7256 to
97707e0
Compare
xiongemi
approved these changes
May 27, 2024
ndcunningham
pushed a commit
that referenced
this pull request
May 28, 2024
#26132) …on screen <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> When multiselect prompts have too many choices, `enquirer` does weird unexpected things with the terminal. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Multiselect prompts are limited to enough lines so that they fit in the terminal view preventing unexpected behavior. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
FrozenPandaz
added a commit
that referenced
this pull request
May 28, 2024
#26132) …on screen <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> When multiselect prompts have too many choices, `enquirer` does weird unexpected things with the terminal. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Multiselect prompts are limited to enough lines so that they fit in the terminal view preventing unexpected behavior. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit e8b0972)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on screen
Current Behavior
When multiselect prompts have too many choices,
enquirerdoes weird unexpected things with the terminal.Expected Behavior
Multiselect prompts are limited to enough lines so that they fit in the terminal view preventing unexpected behavior.
Related Issue(s)
Fixes #