Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add missing bun PM support #26084

Merged
merged 1 commit into from
May 27, 2024

Conversation

Jordan-Hall
Copy link
Contributor

This fix add support for bun PM in daemon and affected changes.

Helps towards #26053 fix

@Jordan-Hall Jordan-Hall requested review from a team as code owners May 25, 2024 20:32
Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 26, 2024 11:24pm

@Jordan-Hall Jordan-Hall force-pushed the fix/missing-bun-support branch from 803da0e to 5e0471c Compare May 25, 2024 20:44
@Jordan-Hall Jordan-Hall changed the title fix(core): addd missing bun PM support fix(core): add missing bun PM support May 25, 2024
@Jordan-Hall Jordan-Hall force-pushed the fix/missing-bun-support branch from 5e0471c to f2b0411 Compare May 25, 2024 20:45
@benpsnyder
Copy link
Contributor

Will probably also fix #25965
@FrozenPandaz this one is high priority for us to keep working on bun support. Once it closes I will keep updating https://github.com/benpsnyder/nx-bun-testing

@Jordan-Hall
Copy link
Contributor Author

Will probably also fix #25965

#25985 will resolve that issue for you.

This fix add support for bun PM in daemon and affected changes
@Jordan-Hall Jordan-Hall force-pushed the fix/missing-bun-support branch from f2b0411 to c81539f Compare May 26, 2024 23:22
@Jordan-Hall Jordan-Hall requested a review from a team as a code owner May 26, 2024 23:22
@Jordan-Hall Jordan-Hall requested a review from jaysoo May 26, 2024 23:22
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 4cbb0f0 into nrwl:master May 27, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request May 28, 2024
This fix add support for bun PM in daemon and affected changes.

Helps towards #26053 fix

(cherry picked from commit 4cbb0f0)
Copy link

github-actions bot commented Jun 7, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants