Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): cache getting the package manager to the module scope #25992

Merged
merged 1 commit into from
May 24, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

This function is called many times and they all exec a command

Expected Behavior

This function is called once and the result is cached.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner May 24, 2024 01:21
@FrozenPandaz FrozenPandaz requested a review from xiongemi May 24, 2024 01:21
Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 24, 2024 1:32am

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) May 24, 2024 01:35
@FrozenPandaz FrozenPandaz merged commit 12c6a73 into master May 24, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-package-json-perf branch May 24, 2024 02:07
FrozenPandaz added a commit that referenced this pull request May 24, 2024
)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

This function is called many times and they all `exec` a command

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

This function is called once and the result is cached.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 12c6a73)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants