Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): only depend on eslint v8 #25938

Merged
merged 1 commit into from
May 23, 2024
Merged

fix(linter): only depend on eslint v8 #25938

merged 1 commit into from
May 23, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented May 23, 2024 •
edited
Loading

Current Behavior

@nx/eslint is bringing in eslint v9 prematurely.

Expected Behavior

@nx/eslint should not bring in eslint v9 yet. Though, it does have support for having v9 installed at the workspace level.

Related Issue(s)

Fixes #25319

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner May 23, 2024 16:48
@FrozenPandaz FrozenPandaz requested a review from meeroslav May 23, 2024 16:48
@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 23, 2024 4:58pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 23, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f2e274e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) May 23, 2024 16:58
@FrozenPandaz FrozenPandaz merged commit f728058 into master May 23, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the eslint-dep branch May 23, 2024 17:23
FrozenPandaz added a commit that referenced this pull request May 23, 2024
@FrozenPandaz
fix(linter): only depend on eslint v8 (#25938)
319d609 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

`@nx/eslint` is bringing in `eslint v9` prematurely.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

`@nx/eslint` should not bring in `eslint v9` yet. Though, it does have
support for having `v9` installed at the workspace level.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #25319

(cherry picked from commit f728058)
FrozenPandaz added a commit that referenced this pull request May 23, 2024
@FrozenPandaz
fix(linter): only depend on eslint v8 (#25938)
2b5efdc 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

`@nx/eslint` is bringing in `eslint v9` prematurely.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

`@nx/eslint` should not bring in `eslint v9` yet. Though, it does have
support for having `v9` installed at the workspace level.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #25319

(cherry picked from commit f728058)
@robertIsaac
Copy link
Contributor

Hi @FrozenPandaz
Isn't nx support eslint 9 in #24632
I'm confused now
Does nx support eslint 9 or not

@robertIsaac robertIsaac mentioned this pull request May 24, 2024
Open
7 tasks
@astroanu
Copy link

Does not fully support i guess

@JamesHenry
Copy link
Collaborator

@robertIsaac @astroanu Per the description on this PR, it should work fine to install eslint v9 at the root of your workspace if you want to.

This change just fixes the issue that Nx was briefly forcing eslint v9 upon users before they were ready. We are going to look into changing this dependency into a peer dependency in a follow up. It was originally done to keep yarn v1/classic happy I believe

@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav is a code owner automatically assigned from nrwl/nx-linter-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint breaks after updating from 19.0.5 to 19.0.6
4 participants
@FrozenPandaz @robertIsaac @astroanu @JamesHenry