Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix buildTargetFromScript takes a long time #25209

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented May 22, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #25923

@xiongemi xiongemi requested a review from a team as a code owner May 22, 2024 22:15
@xiongemi xiongemi requested a review from AgentEnder May 22, 2024 22:15
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 23, 2024 6:26pm

@xiongemi xiongemi force-pushed the feature/nxc-671-buildtargetfromscript-takes-a-long-time-to-identify-the branch from d958f3e to b0c5c89 Compare May 23, 2024 15:50
@xiongemi xiongemi force-pushed the feature/nxc-671-buildtargetfromscript-takes-a-long-time-to-identify-the branch from b0c5c89 to 82d6736 Compare May 23, 2024 16:08
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) May 23, 2024 16:58
@jd-carroll
Copy link

Any chance we can get this merged / deployed?

This is killing my workflow and 48s x the number of times I try to run a cli command (100's) means there is legitimate reason to invest time in switching to a different tool.

@FrozenPandaz
Copy link
Collaborator

Any chance we can get this merged / deployed?

Don't worry, we will get this deployed as soon as possible.

@xiongemi xiongemi force-pushed the feature/nxc-671-buildtargetfromscript-takes-a-long-time-to-identify-the branch from 82d6736 to ca2574f Compare May 23, 2024 18:16
@FrozenPandaz FrozenPandaz disabled auto-merge May 23, 2024 18:44
@FrozenPandaz FrozenPandaz merged commit 94707d9 into nrwl:master May 23, 2024
3 of 6 checks passed
FrozenPandaz pushed a commit that referenced this pull request May 23, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #25923

(cherry picked from commit 94707d9)
FrozenPandaz pushed a commit that referenced this pull request May 23, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #25923

(cherry picked from commit 94707d9)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx / Lerna Running Slow
3 participants