feat(core): allow executor definition to point to another executor #23576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8c336f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
May 20, 2024
Comment on lines
+1224
to
+1228
| if (typeof executorConfig === 'string') { | ||
| // Angular CLI can have a builder pointing to another package:builder | ||
| const [packageName, executorName] = executorConfig.split(':'); | ||
| return this.readExecutorsJson(packageName, executorName); | ||
| } |
There was a problem hiding this comment.
Interesting, this is something like this right?:
{
"builders": {
"build": "@company/other-pkg:build"
}
}There was a problem hiding this comment.
FrozenPandaz
pushed a commit
that referenced
this pull request
May 21, 2024
…23576) Add support for executor definitions that point to another executor. The upcoming Angular 18 uses this feature: https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/builders.json#L4, so we need to be able to resolve the builders correctly using such a configuration. Note: the change is also in [the Angular 18 PR](#22509), where it's tested with the Angular version that requires it. I'm extracting the change to this PR to facilitate reviews and reduce the size of the Angular 18 PR. <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit c240c26)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for executor definitions that point to another executor. The upcoming Angular 18 uses this feature: https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/builders.json#L4, so we need to be able to resolve the builders correctly using such a configuration.
Note: the change is also in the Angular 18 PR, where it's tested with the Angular version that requires it. I'm extracting the change to this PR to facilitate reviews and reduce the size of the Angular 18 PR.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #