feat(core): allow skipping lockfile for affected #23509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f1b930b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
feat/smart-lockfile-affected
branch
4 times, most recently
from
96032c6 to
f558a8c
Compare
AgentEnder
force-pushed
the
feat/smart-lockfile-affected
branch
from
f558a8c to
931992a
Compare
FrozenPandaz
requested changes
Jun 4, 2024
| @@ -303,7 +303,7 @@ const handleWorkspaceChanges: FileWatcherCallback = async ( | |||
| let error = typeof err === 'string' ? new Error(err) : err; | |||
| serverLogger.watcherLog( | |||
| 'Unexpected workspace watcher error', | |||
| error.message | |||
| error?.message | |||
Comment on lines
100
to
105
| export function getPackageName(name: string) { | ||
| if (name.startsWith('@')) { | ||
| return name.split('/').slice(0, 2).join('/'); | ||
| } | ||
| return name.split('/')[0]; | ||
| } |
There was a problem hiding this comment.
I believe we have this here. Could you move it somewhere and export it?
|
|
||
| if ('packageName' in npmPackage.data) { | ||
| if (globalPackages.has(npmPackage.data.packageName)) { | ||
| touched.push(...Object.keys(projectGraph.nodes)); |
AgentEnder
force-pushed
the
feat/smart-lockfile-affected
branch
from
931992a to
f1b930b
Compare
FrozenPandaz
approved these changes
Jun 4, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We consider the full lockfile when determining affected projects
Expected Behavior
There is a way to opt into the smarter affected logic as well keep the full-lockfile for partial projects
Related Issue(s)
Fixes #