Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): properly remove <base> tag when generating static graph file #23399

Merged
merged 1 commit into from
May 15, 2024

Conversation

MaxKless
Copy link
Collaborator

@MaxKless MaxKless commented May 15, 2024

the <base href="/" /> tag was changed to <base href="/"> recently. Probably a third-party update?
Either way, the replacement logic for building a local .html file is updated to handle both cases and be resilient to future changes.

@MaxKless MaxKless requested a review from a team as a code owner May 15, 2024 11:25
@MaxKless MaxKless requested a review from FrozenPandaz May 15, 2024 11:25
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 11:58am

@MaxKless MaxKless force-pushed the fix-graph-file-html branch from 73bfb72 to fd5f345 Compare May 15, 2024 11:56
@MaxKless MaxKless merged commit 5221103 into master May 15, 2024
6 checks passed
@MaxKless MaxKless deleted the fix-graph-file-html branch May 15, 2024 13:31
FrozenPandaz pushed a commit that referenced this pull request May 15, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants