fix(react): respect unitTestRunner passed to the generator #23383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 038bf3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
approved these changes
May 14, 2024
ndcunningham
force-pushed
the
fix/react-vite-jest
branch
3 times, most recently
from
9f3c329 to
497341d
Compare
ndcunningham
commented
May 15, 2024
| @@ -163,7 +163,6 @@ describe('nx init (for React - legacy)', () => { | |||
| ); | |||
|
|
|||
| const packageJson = readJson('package.json'); | |||
| expect(packageJson.devDependencies['@nx/jest']).toBeUndefined(); | |||
There was a problem hiding this comment.
jest is the default so if the unitTestRunner is not set "none" this will be used.
xiongemi
reviewed
May 15, 2024
ndcunningham
force-pushed
the
fix/react-vite-jest
branch
from
497341d to
10c6439
Compare
xiongemi
approved these changes
May 15, 2024
ndcunningham
force-pushed
the
fix/react-vite-jest
branch
3 times, most recently
from
1a9aaf6 to
fcd0e2b
Compare
ndcunningham
force-pushed
the
fix/react-vite-jest
branch
from
fcd0e2b to
038bf3e
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
May 21, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #22276