fix(core): read socket dir on demand & load .env files on client startup #23348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2b68353. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
4 tasks
MaxKless
force-pushed
the
read-daemon-socket-dir-from-dotenv
branch
from
83ee805 to
2b68353
Compare
FrozenPandaz
approved these changes
May 14, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 14, 2024
…tup (#23348) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior The daemon doesn't correctly read the `NX_DAEMON_SOCKET_DIR` env variable if it's set in `.env`. Also, the `.env` files aren't loaded if the daemon client is imported & used directly (like it is in Nx Console). ## Expected Behavior The daemon should correctly read the `NX_DAEMON_SOCKET_DIR` variable regardless of where it's specified and setting it shouldn't cause any issues with Nx Console. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes nrwl/nx-console#2114 (cherry picked from commit 6c36bef)
Coly010
pushed a commit
that referenced
this pull request
May 15, 2024
…tup (#23348) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior The daemon doesn't correctly read the `NX_DAEMON_SOCKET_DIR` env variable if it's set in `.env`. Also, the `.env` files aren't loaded if the daemon client is imported & used directly (like it is in Nx Console). ## Expected Behavior The daemon should correctly read the `NX_DAEMON_SOCKET_DIR` variable regardless of where it's specified and setting it shouldn't cause any issues with Nx Console. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes nrwl/nx-console#2114
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The daemon doesn't correctly read the
NX_DAEMON_SOCKET_DIRenv variable if it's set in.env.Also, the
.envfiles aren't loaded if the daemon client is imported & used directly (like it is in Nx Console).Expected Behavior
The daemon should correctly read the
NX_DAEMON_SOCKET_DIRvariable regardless of where it's specified and setting it shouldn't cause any issues with Nx Console.Related Issue(s)
Fixes nrwl/nx-console#2114