Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): adjust deprecation messages to v20 #23223

Merged
merged 1 commit into from
May 9, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented May 7, 2024

Breaking Changes:

BREAKING CHANGE: nx print-affected was deprecated in 16.4.0 and has been removed.
BREAKING CHANGE: nx affected:graph was deprecated in 16.4.0 and has been removed.
BREAKING CHANGE: The criticalPath and affectedProjects properties of the JSON created by nx graph --file graph.json was deprecated in 16.2.0 and has been removed.

Current Behavior

Some deprecation messages still reference v19.

nx print-affected was deprecated in 16.4.0 to be removed in Nx 19 but was not removed.
nx affected:graph was deprecated in 16.4.0 to be removed in Nx 19 but was not removed.

Expected Behavior

Deprecation messages reference v20 now.

nx print-affected is removed.
nx affected:graph is removed.

There are redirects to a deprecated page describing those commands for Nx users using Nx <19

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team and Coly010 as code owners May 7, 2024 18:48
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 9, 2024 0:04am

@isaacplmann
Copy link
Collaborator

You force pushed without verify and skipped running the nx documentation script in the git push hook. All the generated docs are deleted

@FrozenPandaz FrozenPandaz merged commit 8f705e3 into nrwl:master May 9, 2024
6 checks passed
FrozenPandaz added a commit that referenced this pull request May 9, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Breaking Changes:

BREAKING CHANGE: `nx print-affected` was deprecated in 16.4.0 and has
been removed.
BREAKING CHANGE: `nx affected:graph` was deprecated in 16.4.0 and has
been removed.
BREAKING CHANGE: The `criticalPath` and `affectedProjects` properties of
the JSON created by `nx graph --file graph.json` was deprecated in
16.2.0 and has been removed.

## Current Behavior
<!-- This is the behavior we have today -->

Some deprecation messages still reference v19.

`nx print-affected` was deprecated in 16.4.0 to be removed in Nx 19 but
was not removed.
`nx affected:graph` was deprecated in 16.4.0 to be removed in Nx 19 but
was not removed.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Deprecation messages reference v20 now.

`nx print-affected` is removed.
`nx affected:graph` is removed.

There are redirects to a `deprecated` page describing those commands for
Nx users using Nx <19

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 8f705e3)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants